Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EEG] Database Architecture for HED Tags #8036

Merged
merged 7 commits into from
Jun 28, 2022
Merged

[EEG] Database Architecture for HED Tags #8036

merged 7 commits into from
Jun 28, 2022

Conversation

jesscall
Copy link
Contributor

@jesscall jesscall commented Mar 3, 2022 •
edited
Loading

Brief summary of changes

This PR contains the necessary changes for adding HED Tag support to the database.

There is a single use script that should be run to archive the events files.

❗ Blocked ❗
Necessary changes will also have to be made to the LORIS-MRI code. PR #769

Testing instructions (if applicable)

  1. Try to source the schema / run patch.
  2. Run script in this PR to archive the events. cd tools/single_use/ && php archive_eeg_event_files.php
  3. Make sure EEG Browser download links for event files still works.

@jesscall jesscall added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Mar 3, 2022
@jesscall jesscall mentioned this pull request Mar 8, 2022
Closed
@jesscall jesscall mentioned this pull request Mar 9, 2022
Merged
cmadjar
cmadjar approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@driusan driusan merged commit e781689 into aces:main Jun 28, 2022
@kongtiaowang kongtiaowang mentioned this pull request Jul 14, 2022
Merged
@christinerogers christinerogers removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Aug 2, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmadjar cmadjar cmadjar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jesscall @cmadjar @driusan @christinerogers @ridz1208